Project

General

Profile

Actions

Issue #1179

closed

project external/google contains analytics and market related stuff

Added by Robert Schultz almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
01/15/2015
Due date:
% Done:

0%

Estimated time:
Resolution:
fixed
Device:
Grant:
Type of work:

Description

In the manifest's default.xml contains <project path="external/google" name="CyanogenMod/android_external_google" />. This folder contains jar files from play, gcm, admob, market_licensing etc. Just wondering if this is removable to make it clean and lean! Or perhaps it does not matter?
Great work!

Actions #1

Updated by Robert Schultz almost 8 years ago

I meant "great work" not as a sarcasm. Truly, I appreciate replicant :-)

Actions #2

Updated by Daniel Kulesz almost 8 years ago

You are refering to line 261 in the current default.xml of the 4.2 branch, right? I see the entry there as well.

Did you try to drop it and recompile without it?

Actions #3

Updated by Paul Kocialkowski almost 8 years ago

Did you try to drop it and recompile without it?

I just did, it apparently works fine.

Actions #4

Updated by Paul Kocialkowski almost 8 years ago

I'll build all the targets on the builder and see if it affects any.

Actions #5

Updated by Paul Kocialkowski almost 8 years ago

  • Status changed from New to Closed
  • Resolution set to fixed

Everything builds fine, this was not necessary nor included. I didn't look in-depth, but there may have been proprietary components in there. Manifest commit: https://gitorious.org/replicant/manifest/commit/d921ee65af81d266fefc6cfa146c74f488208bcf

Thanks for the report!

Actions

Also available in: Atom PDF