Project

General

Profile

Actions

Issue #1293

closed

Require https for f-droid.org prebuilt downloads

Added by Steven Chamberlain over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Category:
Security
Target version:
-
Start date:
07/31/2015
Due date:
% Done:

0%

Estimated time:
Resolution:
fixed
Device:
Grant:
Type of work:

Description

Hi!

When fetching prebuilt binaries from f-droid.org, we were using http,
but are now redirected to a https URI - unless a MITM attacker gets
there first...

Change to unconditionally use https to fetch prebuilt binaries.

While here, set -e so that failure to download any file is not ignored.

Patch attached. Thanks.


Files

Actions #1

Updated by My Self over 8 years ago

Thanks for that patch.
I patched it (under vendor/replicant/) and after that the script vendor/replicant/get-prebuilts worked as good as the following Replicant (4.2) build process.

Actions #2

Updated by Paul Kocialkowski over 8 years ago

Looks good, I'll merge that soon. Sorry for the delay and thanks for your work!

Actions #3

Updated by Paul Kocialkowski over 8 years ago

  • Status changed from New to Closed
  • Resolution set to fixed

Merged, thanks again!

Actions

Also available in: Atom PDF