Project

General

Profile

Actions

Issue #1461

closed

Need little help on fixing an issue on hardcoded alarm settings intent

Added by My Self about 7 years ago. Updated almost 7 years ago.

Status:
Rejected
Priority:
Low
Category:
Framework
Target version:
Start date:
11/24/2015
Due date:
% Done:

10%

Estimated time:
Resolution:
invalid
Device:
Grant:
Type of work:

Description

I replaced my Clock system-app, because of this: http://redmine.replicant.us/boards/9/topics/11733

Now, I want to use the 'dynamic tile' -> 'Alarm clock' of the 'quick settings panel' (to be found here: Settings -> System -> Quick Settings panel -> (Dynamic Tiles) Alarm clock [X]).

So If I create/activate an alarm, a clock symbol appears in the status bar. If I slide down the quick settings panel, the dynamic tile alarm clock appears, too. When I tabbed on that symbol in the past, with the AOSP Clock (DeskClock) installed, the alarm clock settings came up.
Now, the alternative alarm app doesn't come up, because the DeskClock app seems to be hardcoded to that quick settings tile.

Logcat says:
PID Event Message
2890 I ActivityManager START u0 {flg=0x14000000 cmp=com.android.deskclock/.AlarmClock} from pid 3005
2890 W InputMethodManagerService Window already focused, ignoring focus gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@4234bd80 attribute=null, token = android.os.BinderProxy@4203eae8

So I searched a bit and found a patch for that issue, here: https://github.com/CyanogenMod/android_frameworks_base/commit/c44f7a251a1e4480804dee4987ce9b6237f28a7d which I brought to Replicant, (Fix-an-issue-on-hardcoded-alarm-settings-intent.patch attached).
But after successfully recompiling / reflashing the new Replicant image, the logcat message doesn't change and I still can't open alternative clock apps from the quick settings panel.

I've searched for more hardcoded parts inside the Replicant codebase, but can't find useful/related files:

find . -type f -exec grep -il "com.google.android.deskclock" {} \;
  • ./frameworks/base/tools/preload/20100223.compiled
  • ./frameworks/base/tools/preload/Policy.java
  • ./frameworks/base/core/res/res/values/config.xml
  • ./packages/apps/LockClock/src/com/cyanogenmod/lockclock/misc/WidgetUtils.java

It would be really great if somebody could give me a little help here.


Files

Actions #1

Updated by Paul Kocialkowski about 7 years ago

Well, looks like ./packages/apps/LockClock/src/com/cyanogenmod/lockclock/misc/WidgetUtils.java has the name hardcoded in getDefaultAlarmsIntent, so perhaps the patch you applied also requires some more patching in there. Also, I'm not sure that declaring the permission in the manifest is enough, the permission probably has to be declared somewhere else to be effective.

It's probably not very straightforward to collect all the pieces needed for this to work, sadly.

Actions #2

Updated by Denis 'GNUtoo' Carikli almost 7 years ago

  • Category changed from 51 to Framework
  • Device Not device specific added
Actions #3

Updated by Paul Kocialkowski almost 7 years ago

  • Status changed from New to Rejected
  • Resolution set to invalid
  • Device added
  • Device deleted (Not device specific)

Note that this is not an issue about Replicant, you should bring this up in the forums if need be.

Actions

Also available in: Atom PDF