Project

General

Profile

Actions

Issue #1807

closed

git tag verification fails on cts in replicant-6.0 i9100

Added by R B almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Build system
Target version:
Start date:
05/22/2017
Due date:
% Done:

0%

Estimated time:
Resolution:
fixed
Device:
Grant:
Type of work:

Description

running the command: "git verify-tag $(git describe)" in the directory "replicant-6.0/cts" gives the following:

error: android-cts-6.0_r18-23-g5ef4e2beae: cannot verify a non-tag object of type commit.

All other repos succeed with verification. I tried deleting the cts directory and running 'repo sync' again with no change.

Actions #1

Updated by Wolfgang Wiedmeyer almost 7 years ago

  • Assignee set to Wolfgang Wiedmeyer
  • Device added
  • Device deleted (Galaxy S 2 (I9100))

Thanks for reporting this!

The reason is that for the CTS, a branch is checked out and not an actual tag. I only had thought Google engineers would always add a signed tag to the latest merge commit on that release branch. This was the case when I created the release but it's not the case right now which causes this error. The commit that will currently be checked out has no corresponding tag. I will fix this for the next release and directly use the latest tag as revision. This should not happen for other repos as the CTS repo is the last remaining default repo on the release branch where a tag isn't directly used as a revision.

For now, I added a note to the wiki page pointing to this issue.

Actions #2

Updated by Wolfgang Wiedmeyer over 6 years ago

  • Status changed from New to Closed
  • Resolution set to fixed

Fixed with the latest releases.

Actions

Also available in: Atom PDF