Project

General

Profile

Feature #1832

Add shell scripts for enabling/disabling llvmpipe

Added by Jeremy Rand over 2 years ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Category:
Graphics
Target version:
Start date:
09/10/2017
Due date:
% Done:

100%

Estimated time:
Resolution:
fixed
Device:

Description

Attached is a patch for user-scripts that allows switching between llvmpipe and Android Software Renderer. (Its setup.sh incorporates the improvements from https://redmine.replicant.us/issues/1831 )


Files

6.0-llvmpipe.patch (4.81 KB) 6.0-llvmpipe.patch Jeremy Rand, 09/10/2017 08:03 AM

Related issues

Blocks Replicant - Issue #1960: Build release candidate image for 6.0 0004Closed10/09/2019

Actions

History

#1

Updated by Jeremy Rand over 2 years ago

  • Assignee set to Wolfgang Wiedmeyer

Hi Wolfgang, any chance you could review this patch? Thanks!

#2

Updated by Kurtis Hanna almost 2 years ago

  • Target version changed from Replicant 6.0 to Replicant 6.0 0004
#3

Updated by Fil Bergamo over 1 year ago

  • Tracker changed from Issue to Feature
#4

Updated by Denis 'GNUtoo' Carikli about 1 year ago

  • Status changed from New to Feedback

In order to be integrated in the next Replicant release (0004), the patches have to be sent on the mailing list so we could collectively review them.

Thanks a lot for working on that.

#5

Updated by Denis 'GNUtoo' Carikli 7 months ago

Hi,

Can you send the patch to the mailing list so we could review it and include it in the Replicant 6.0 0004 release?

Denis.

#6

Updated by dl lud 7 months ago

That has been done already, check: https://lists.osuosl.org/pipermail/replicant/2019-October/002164.html
The only missing thing is sane defaults, like adjtm has on his experimental builds: llvmpipe as the default renderer for everything except SurfaceFlinger.

#7

Updated by Denis 'GNUtoo' Carikli 6 months ago

That has been done already, check: https://lists.osuosl.org/pipermail/replicant/2019-October/002164.html

I looked fast and I didn't see any script in the list of patches.

The subject of this bug report is (now?) "Add shell scripts for enabling/disabling llvmpipe" so here I'm assuming that we could merge the script in vendor/replicant-scripts which has been renamed from user-scripts.

I've already merged the patches to ship some of the other scripts directly on the device.

I will test it again better to see if the Android.mk are picked automatically and send a patch to the manifest, so we could now get the scripts automatically on the device.

#8

Updated by dl lud 6 months ago

You are correct, this script wasn't part of the patchset. I have now reviewed it against the current code on frameworks_native/blob/opengl/libs/EGL/Loader.cpp. It is still applicable and should work as expected. Seems safe to merge.

#9

Updated by Kurtis Hanna 6 months ago

  • Blocks Issue #1960: Build release candidate image for 6.0 0004 added
#10

Updated by Kurtis Hanna 6 months ago

  • % Done changed from 0 to 50

The plan, based on my understanding of IRC discussions, is to add this script before building the 0004 release candidate. Due to this, I added this issue as a blocker to #1960. If someone could write a patch to add this, that'd be great.

#11

Updated by Denis 'GNUtoo' Carikli 6 months ago

  • Assignee changed from Wolfgang Wiedmeyer to Denis 'GNUtoo' Carikli

The patches for that are being reviewed on the mailing list.

Feel free to review some if you want.

It would enable not to wait 1 week for pushing them.

#12

Updated by Kurtis Hanna 5 months ago

  • Status changed from Feedback to Resolved
  • Resolution set to fixed

The patch to fix this was pushed. https://lists.osuosl.org/pipermail/replicant/2019-December/002371.html

Closing this issue.

#13

Updated by Kurtis Hanna 5 months ago

  • % Done changed from 50 to 100

Also available in: Atom PDF