Feature #1903
closedImplement a lookup settings reset when Dialer app is first run
100%
Description
This is related to issue #1827, that is solved in the new release of Replicant 6.0.
To solve the issue in already-installed environments, the Dialer app should be patched to do the following when it is run for the first time after a system upgrade:
- Reset all settings regarding lookup anti-features to "Disabled"
- Keep track of the one-time-change in the shared settings SQLite database
- Leave settings unchanged during subsequent runs, to allow users to adjust them as they wish.
Related issues
Updated by Denis 'GNUtoo' Carikli over 5 years ago
- Target version changed from Replicant 6.0 0005 to Replicant 6.0 0004
Updated by Denis 'GNUtoo' Carikli over 5 years ago
Hi,
I've been thinking about it, and I think it makes more sense not to support this anti-feature.
Most users are most probably not willing to give potentially very private information to the companies operating the phone lookup services, just to get a precise indication of where the phone number is located.
I think it would make more sense to disable that feature completely.
If some users really want it back, we could then try to think about which requirements (like not violating users's privacy) we should require in to accept a patch that can restore the feature.
Denis.
Updated by Fil Bergamo over 5 years ago
Denis 'GNUtoo' Carikli wrote:
Hi,
I've been thinking about it, and I think it makes more sense not to support this anti-feature.
Most users are most probably not willing to give potentially very private information to the companies operating the phone lookup services, just to get a precise indication of where the phone number is located.
Well, it makes sense to me too, personally. And it would also be much easier for me to just remove the anti-feature completely, compared to implementing a reset of the default settings.
Some users may still want to be able to use those services, though; I don't like the idea of cutting it off completely.
Also, consider that by resetting the default options to "off", the anti-feature would only be restored by an explicit action performed by the user in the dialer's settings GUI.
I think it is safe enough to just disable the option by default and let users chose to enable it explicitly if they wish so. This would both guarantee users' privacy and keep the opportunity to enable the service if any user wants it, without the need of an additional patch to bring it back in the future.
For a more complete solution, it's also possible to implement a graphical warning explaining the implied privacy concerns when the user tries to enable the anti-features.
Updated by Denis 'GNUtoo' Carikli over 5 years ago
- Assignee changed from Fil Bergamo to Denis 'GNUtoo' Carikli
Updated by Joonas Kylmälä almost 5 years ago
- Assignee changed from Denis 'GNUtoo' Carikli to Joonas Kylmälä
- Parent task deleted (
#1827)
I will have a try with this.
Updated by Kurtis Hanna almost 5 years ago
- Related to Issue #1960: Build release candidate image for 6.0 0004 added
Updated by Kurtis Hanna almost 5 years ago
- Related to deleted (Issue #1960: Build release candidate image for 6.0 0004)
Updated by Kurtis Hanna almost 5 years ago
- Blocks Issue #1960: Build release candidate image for 6.0 0004 added
Updated by Kurtis Hanna almost 5 years ago
Since we would like to build a release candidate of 6.0 0004 within the week and this issue blocks it, I suggest that we disable the feature completely since a patch that provides a more complete solution, like the one suggested by Fil, hasn't been written.
Updated by Kurtis Hanna almost 5 years ago
- Status changed from New to Feedback
Joonas' patch was sent to the mailing list for review: https://lists.osuosl.org/pipermail/replicant/2019-October/002129.html
Updated by Joonas Kylmälä almost 5 years ago
- Status changed from Feedback to In Progress
Patches are pending for review on the mailing list.
Updated by Joonas Kylmälä almost 5 years ago
- Status changed from In Progress to Feedback
Updated by Joonas Kylmälä almost 5 years ago
- Status changed from Feedback to Resolved
- % Done changed from 0 to 100
- Resolution set to fixed