Project

General

Profile

Issue #2074

libsamsung-ipc: Android.mk: LOCAL_COPY_HEADERS is deprecated

Added by Denis 'GNUtoo' Carikli 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Category:
Telephony and mobile data
Target version:
Start date:
07/08/2020
Due date:
% Done:

0%

Estimated time:
Resolution:
fixed
Device:
Unknown
Grant:
#1

Updated by Denis 'GNUtoo' Carikli 4 months ago

Reference: https://android.googlesource.com/platform/build/soong/+/master/docs/best_practices.md#headers

Thanks to Putti on #replicant for pointing me that.

LOCAL_EXPORT_C_INCLUDE_DIRS is also used in Replicant 6.0:

art/disassembler/Android.mk:  LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
build/core/binary.mk:my_export_c_include_dirs := $(LOCAL_EXPORT_C_INCLUDE_DIRS)
build/core/clear_vars.mk:LOCAL_EXPORT_C_INCLUDE_DIRS:=
build/core/prebuilt_internal.mk:$(export_includes): PRIVATE_EXPORT_C_INCLUDE_DIRS := $(LOCAL_EXPORT_C_INCLUDE_DIRS)
build/core/prebuilt_internal.mk:ifdef LOCAL_EXPORT_C_INCLUDE_DIRS
external/boringssl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/src/include
external/boringssl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/src/include
external/boringssl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/src/include
external/boringssl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
external/boringssl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/src/include
external/boringssl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/src/include
external/boringssl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/src/include
external/boringssl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/src/include
external/bzip2/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/bzip2/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/curl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
external/curl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
external/drm_gralloc/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := \
external/e2fsprogs/lib/uuid/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/e2fsprogs/lib/uuid/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/e2fsprogs/lib/uuid/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/e2fsprogs/lib/uuid/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libdw/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libdw/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libdwelf/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libdwelf/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libdwfl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libdwfl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libebl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libebl/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libelf/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/elfutils/src/libelf/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/google-breakpad/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_C_INCLUDES)
external/icu/android_utils/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
external/icu/android_utils/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
external/icu/icu4c/source/common/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
external/icu/icu4c/source/common/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)

And in Replicant 4.2:

build/core/binary.mk:$(export_includes): PRIVATE_EXPORT_C_INCLUDE_DIRS := $(LOCAL_EXPORT_C_INCLUDE_DIRS)
build/core/binary.mk:ifdef LOCAL_EXPORT_C_INCLUDE_DIRS
build/core/clear_vars.mk:LOCAL_EXPORT_C_INCLUDE_DIRS:=
hardware/samsung_slsi/exynos5/libcsc/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
hardware/samsung_slsi/exynos5/libcsc/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
hardware/samsung_slsi/exynos5/mobicore/daemon/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS +=\
ndk/sources/android/cpufeatures/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)
system/core/fs_mgr/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
system/core/libsparse/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
system/core/libsparse/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
system/core/libsparse/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
system/core/libsuspend/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include
system/core/libsuspend/Android.mk:LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include

I'll check if with Replicant >= 4.2 we have all devices supported by libsamsung-ipc.

#2

Updated by Denis 'GNUtoo' Carikli 4 months ago

We should have all devices supported by libsamsung-ipc since 4.2 (I checked with the Images page and completed ReplicantVersions along the way).

#3

Updated by Denis 'GNUtoo' Carikli 4 months ago

  • Target version changed from Any version to Replicant 6.0 0004 RC1

We could try to fix it for the Replicant 6.0 0004 RC1 and if it takes too much time, we could release and try to fix right after.

libsamsung-ipc has been removed from Replicant 10 manifest for now anyway so there is no hurry.

Once it is fixed we also need to add back libsamsung-ipc to the Replicant 10 manifest and then add libsamsung-ril there too once it compiles in a clean enough way (without ugly hack to workaround API changes).

#4

Updated by Denis 'GNUtoo' Carikli 4 months ago

  • Target version changed from Replicant 6.0 0004 RC1 to Replicant 6.0 0004 RC2

fix mistake (it's for RC2 not RC1)

#5

Updated by Denis 'GNUtoo' Carikli 3 months ago

  • Status changed from New to Resolved
  • Assignee set to Denis 'GNUtoo' Carikli
  • Resolution set to fixed

The fix is now in git and in the Replicant 6.0 0004 RC2 images

Also available in: Atom PDF