Actions
Issue #2150
openlibsamsung-ipc: improve board drivers print
Start date:
10/21/2020
Due date:
% Done:
0%
Estimated time:
Resolution:
Device:
Unknown
Grant:
Type of work:
C programming
Actions
Added by Denis 'GNUtoo' Carikli almost 4 years ago. Updated over 3 years ago.
0%
For many devices, we have code like that:
rc = xmm626_kernel_smdk4412_power(client, modem_boot_fd, 1); rc |= xmm626_kernel_smdk4412_hci_power(client, 1); if (rc < 0) { ipc_client_log(client, "Turning the modem on failed"); goto error; }
While it takes more time to write, it would be better to have two distinct
error messages:
rc = xmm626_kernel_smdk4412_power(client, modem_boot_fd, 1); if (rc < 0) { ipc_client_log(client, "Turning the modem on failed"); goto error; } rc = xmm626_kernel_smdk4412_hci_power(client, 1); if (rc < 0) { ipc_client_log(client, "Powering on the HCI bus failed"); goto error; }