Project

General

Profile

Issue #2177

Cleanup midas reboot patch

Added by Denis 'GNUtoo' Carikli 11 months ago. Updated about 1 month ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Linux
Start date:
11/23/2020
Due date:
% Done:

0%

Estimated time:
Upstream patch status:
Work not started
Grant:
Type of work:
C programming
#1

Updated by Denis 'GNUtoo' Carikli 11 months ago

Sensiblemn found this patch:

<@sensiblemn> i was visually comparing the patches on tizen's website with the mainline kernel and noticed one trats2 patch from last year that hasn't 
                    been upstreamed. 
https://git.tizen.org/cgit/platform/kernel/linux-exynos/commit/arch/arm/boot/dts/exynos4412-trats2.dts?h=tizen_6.0&id=84ae2edc1762a22785da4f32785b2b40602ad85b

In my implementation of it I didn't create something like exynos,boot-mode.h because I assumed it wasn't exynos specific:
  • On midas it's implemented in s-boot 4.0, so I've no idea if other exynos boards also have that. We know it's not in the BL1 because u-boot for midas implemented some of theses as well.
  • U-boot also implement these, I also need to update the commit message to mention that, but I didn't have the time to do it yet.

Since they use it, it might be a good idea to pickup their patches about it.

I also wonder how they made download mode work as in my case It switches to download mode but the device is not visible on lsusb while if I do it through the button or reboot from the smdk4412 kernel, it's visible on USB as well.

It might need the shutdown driver as well for instance where it does a cable detection to enable charging at the next boot.

#4

Updated by Kurtis Hanna 11 months ago

This trats2 patch talks about restarting a phone instead of rebooting the phone. https://git.tizen.org/cgit/platform/kernel/u-boot/commit/?h=accepted/tizen_6.0_unified&id=bfeaa9ded2338b7b17a067bee71edab2f5638df7

It looks less relevant but I figured I'd provide it anyways.

#5

Updated by _I3^ RELATIVISM 7 months ago

  • Type of work C programming added
#6

Updated by Denis 'GNUtoo' Carikli about 1 month ago

  • Category set to Linux

Also available in: Atom PDF