Project

General

Profile

ExynosModemIsolation » History » Version 12

Denis 'GNUtoo' Carikli, 03/02/2020 11:09 AM

1 9 Denis 'GNUtoo' Carikli
h1. Exynos 3110 modem isolation
2 1 Paul Kocialkowski
3 11 Denis 'GNUtoo' Carikli
{{toc}}
4
5 7 Denis 'GNUtoo' Carikli
This article talks about a very serious freedom, privacy and security issue we found during Replicant development.
6 1 Paul Kocialkowski
7 9 Denis 'GNUtoo' Carikli
We found that the modem wasn't isolated and was potentially able to read and write part of the RAM used by Replicant on several devices with an Exynos 3110.
8 7 Denis 'GNUtoo' Carikli
9
h2. Affected devices:
10
11 10 Denis 'GNUtoo' Carikli
At least the following devices are affected:
12
13
* Galaxy S (GT-I9000)
14 7 Denis 'GNUtoo' Carikli
* Nexus S (GT-I9020)
15
* Nexus S (GT-I9020A)
16
* Nexus S (GT-I9023)
17
18 1 Paul Kocialkowski
h2. Hardware design matrix
19
20
|_. *Chip* |_. Controlled by the CPU |_. Controlled by the modem |_. Connected to the modem |
21
| GPS | Yes | No | No? |
22
| Audio CODEC | Yes | No | Yes |
23
| NAND | Yes | No | No |
24 3 Paul Kocialkowski
| RAM | Yes | Yes (96Mib at least) | Yes |
25 1 Paul Kocialkowski
| WiFi/Bluetooth | Yes | No | No |
26
| Sensors | Yes | No | No |
27
| NFC | Yes | No | No |
28
| Camera | Yes | No | No |
29
30 5 Denis 'GNUtoo' Carikli
h2. Modem isolation
31 1 Paul Kocialkowski
32 5 Denis 'GNUtoo' Carikli
The modem (XMM 6160) is separated from the SoC and communicates with it via serial over 16Mib of shared memory: this is bad since it means that RAM is compromised (at least 80Mib + 16Mib = 96Mib) and can be used to spy.
33
Regarding audio, the modem is connected to the CODEC but cannot control it (the SoC has to enable routing from/to the modem).
34
There is no evidence that the GPS is connected to the modem, but since we cannot check on the hardware, there is no proof it's not connected to it either. The SoC is able to control the GPS power though, so we can keep it off.
35
Since the SoC has to load the modem firmware over the (fake) serial, and following the datasheets, the modem is not connected to the NAND.
36
37 3 Paul Kocialkowski
The modem is able to spy on (at least) 96 Mib of the main memory. So far, we cannot tell:
38
* if it can only spy 80Mib or the full memory
39 1 Paul Kocialkowski
* if it can be fixed or not
40 4 Paul Kocialkowski
41
The Linux kernel is being loaded at the beginning of the shared memory bank (0x30000000), however the kernel should be off when it loads.
42 1 Paul Kocialkowski
43 12 Denis 'GNUtoo' Carikli
h3. Nexus S (GT-I902x) Kernel details
44 1 Paul Kocialkowski
45 5 Denis 'GNUtoo' Carikli
In "kernel-crespo/arch/arm/mach-s5pv210/dev-herring-phone.c":https://git.replicant.us/replicant/kernel_samsung_crespo/tree/arch/arm/mach-s5pv210/dev-herring-phone.c#n49 we have:
46 1 Paul Kocialkowski
<pre>
47
static struct resource mdmctl_res[] = {
48
[...]
49
        [2] = {
50
                .name = "onedram",
51
                .start = (S5PV210_PA_SDRAM + 0x05000000),
52
                .end = (S5PV210_PA_SDRAM + 0x05000000 + SZ_16M - 1),
53
                .flags = IORESOURCE_MEM,
54
        },
55
};
56
</pre>
57
58
* S5PV210_PA_SDRAM is 0x30000000
59 3 Paul Kocialkowski
* 0x05000000 is 80Mib
60 1 Paul Kocialkowski
* mdmctl_res goes in a platform device struct which is passed to the modem driver:
61
62
<pre>
63
static struct platform_device modemctl = {
64
        .name = "modemctl",
65
        .id = -1,
66
        .num_resources = ARRAY_SIZE(mdmctl_res),
67
        .resource = mdmctl_res,
68
        .dev = {
69
                .platform_data = &mdmctl_data,
70
        },
71
};
72
</pre>
73
74 6 Denis 'GNUtoo' Carikli
And in the board file, in "kernel-crespo/arch/arm/mach-s5pv210/mach-herring.c":https://git.replicant.us/replicant/kernel_samsung_crespo/tree/arch/arm/mach-s5pv210/mach-herring.c#n5596 we have: 
75 1 Paul Kocialkowski
<pre>
76
static void __init herring_fixup(struct machine_desc *desc,
77
                struct tag *tags, char **cmdline,
78
                struct meminfo *mi)
79
{
80
        mi->bank[0].start = 0x30000000;
81
        mi->bank[0].size = 80 * SZ_1M;
82
        mi->bank[0].node = 0;
83
</pre>
84
85 3 Paul Kocialkowski
So we can suppose that there is at least one ram chip that is shared between the modem and the main CPU. Avoiding the use of this memory bank would result in loosing 80Mib of memory.
86 4 Paul Kocialkowski
87 8 Denis 'GNUtoo' Carikli
h3. Workaround attempt
88 1 Paul Kocialkowski
89 8 Denis 'GNUtoo' Carikli
It might be possible to limit the amount of damage by relying on the fact that the modem has to be booted by Replicant, and make sure that the RAM chip that is shared with the modem isn't used for other things than this memory sharing.
90
91
This would make us lose about 80Mib of RAM, and the shared memory would still be used for SoC/Modem communication but as the RAM chip would be used only for that, so the modem would not be able read and write problematic data on it.
92
93
We would also need to make sure that the booloader doesn't load the kernel in that region or that the kernel is relocated to some other region before intializing the modem.
94 4 Paul Kocialkowski
95
The current diff with the Nexus S kernel is here, but it doesn't boot at all with the following changes (and mkbootimg changes):
96
97
<pre>
98
diff --git a/arch/arm/configs/herring_defconfig b/arch/arm/configs/herring_defconfig
99
old mode 100755
100
new mode 100644
101
index 11abbf0..99bf3f5
102
--- a/arch/arm/configs/herring_defconfig
103
+++ b/arch/arm/configs/herring_defconfig
104
@@ -1,7 +1,7 @@
105
 #
106
 # Automatically generated make config: don't edit
107
 # Linux kernel version: 2.6.35.7
108
-# Fri Jun  3 07:07:08 2011
109
+# Sun Apr  8 14:40:16 2012
110
 #
111
 CONFIG_ARM=y
112
 CONFIG_HAVE_PWM=y
113
@@ -418,8 +418,8 @@ CONFIG_ALIGNMENT_TRAP=y
114
 #
115
 CONFIG_ZBOOT_ROM_TEXT=0
116
 CONFIG_ZBOOT_ROM_BSS=0
117
-CONFIG_CMDLINE="console=ttyFIQ0"
118
-# CONFIG_CMDLINE_FORCE is not set
119
+CONFIG_CMDLINE="console=ttyFIQ0 no_console_suspend earlyprintk=serial,ttySAC2,115200 androidboot.serialno=3733BAB66DE200EC androidboot.bootloader=I9020XXKA3 androidboot.baseband=I9020XXKB3 androidboot.info=0x4,0x0,1 androidboot.carrier=EUR gain_code=3 s3cfb.bootloaderfb=0x34a00000 mach-herring.lcd_type=0x00000000 oem_state=unlocked"
120
+CONFIG_CMDLINE_FORCE=y
121
 # CONFIG_XIP_KERNEL is not set
122
 # CONFIG_KEXEC is not set
123
 
124
@@ -823,8 +823,6 @@ CONFIG_UEVENT_HELPER_PATH=""
125
 CONFIG_STANDALONE=y
126
 CONFIG_PREVENT_FIRMWARE_BUILD=y
127
 # CONFIG_FW_LOADER is not set
128
-# CONFIG_FIRMWARE_IN_KERNEL is not set
129
-CONFIG_EXTRA_FIRMWARE=""
130
 # CONFIG_DEBUG_DRIVER is not set
131
 # CONFIG_DEBUG_DEVRES is not set
132
 # CONFIG_SYS_HYPERVISOR is not set
133
@@ -835,7 +833,7 @@ CONFIG_MTD=y
134
 CONFIG_MTD_CONCAT=y
135
 CONFIG_MTD_PARTITIONS=y
136
 # CONFIG_MTD_REDBOOT_PARTS is not set
137
-# CONFIG_MTD_CMDLINE_PARTS is not set
138
+CONFIG_MTD_CMDLINE_PARTS=y
139
 # CONFIG_MTD_AFS_PARTS is not set
140
 # CONFIG_MTD_AR7_PARTS is not set
141
 
142
@@ -1191,6 +1189,7 @@ CONFIG_DEVKMEM=y
143
 CONFIG_SERIAL_SAMSUNG=y
144
 CONFIG_SERIAL_SAMSUNG_UARTS_4=y
145
 CONFIG_SERIAL_SAMSUNG_UARTS=4
146
+# CONFIG_SERIAL_SAMSUNG_DEBUG is not set
147
 CONFIG_SERIAL_SAMSUNG_CONSOLE=y
148
 CONFIG_SERIAL_S5PV210=y
149
 # CONFIG_SERIAL_MAX3100 is not set
150
@@ -2046,7 +2045,9 @@ CONFIG_HAVE_ARCH_KGDB=y
151
 CONFIG_DEBUG_USER=y
152
 CONFIG_DEBUG_ERRORS=y
153
 # CONFIG_DEBUG_STACK_USAGE is not set
154
-# CONFIG_DEBUG_LL is not set
155
+CONFIG_DEBUG_LL=y
156
+CONFIG_EARLY_PRINTK=y
157
+# CONFIG_DEBUG_ICEDCC is not set
158
 CONFIG_OC_ETM=y
159
 CONFIG_DEBUG_S3C_UART=2
160
 
161
diff --git a/arch/arm/mach-s5pv210/dev-herring-phone.c b/arch/arm/mach-s5pv210/dev-herring-phone.c
162
index f8798b3..ecef636 100755
163
--- a/arch/arm/mach-s5pv210/dev-herring-phone.c
164
+++ b/arch/arm/mach-s5pv210/dev-herring-phone.c
165
@@ -48,8 +48,8 @@ static struct resource mdmctl_res[] = {
166
 	},
167
 	[2] = {
168
 		.name = "onedram",
169
-		.start = (S5PV210_PA_SDRAM + 0x05000000),
170
-		.end = (S5PV210_PA_SDRAM + 0x05000000 + SZ_16M - 1),
171
+		.start = (0x30000000  + 0x05000000),
172
+		.end = (0x30000000  + 0x05000000 + SZ_16M - 1),
173
 		.flags = IORESOURCE_MEM,
174
 	},
175
 };
176
diff --git a/arch/arm/mach-s5pv210/mach-herring.c b/arch/arm/mach-s5pv210/mach-herring.c
177
index c3a0182..67fa1cf 100755
178
--- a/arch/arm/mach-s5pv210/mach-herring.c
179
+++ b/arch/arm/mach-s5pv210/mach-herring.c
180
@@ -5494,21 +5494,17 @@ static void __init herring_fixup(struct machine_desc *desc,
181
 		struct tag *tags, char **cmdline,
182
 		struct meminfo *mi)
183
 {
184
-	mi->bank[0].start = 0x30000000;
185
-	mi->bank[0].size = 80 * SZ_1M;
186
+	mi->bank[0].start = 0x40000000;
187
+	mi->bank[0].size = 256 * SZ_1M;
188
 	mi->bank[0].node = 0;
189
 
190
-	mi->bank[1].start = 0x40000000;
191
-	mi->bank[1].size = 256 * SZ_1M;
192
-	mi->bank[1].node = 1;
193
-
194
-	mi->bank[2].start = 0x50000000;
195
+	mi->bank[1].start = 0x50000000;
196
 	/* 1M for ram_console buffer */
197
-	mi->bank[2].size = 127 * SZ_1M;
198
-	mi->bank[2].node = 2;
199
-	mi->nr_banks = 3;
200
+	mi->bank[1].size = 127 * SZ_1M;
201
+	mi->bank[1].node = 1;
202
+	mi->nr_banks = 2;
203
 
204
-	ram_console_start = mi->bank[2].start + mi->bank[2].size;
205
+	ram_console_start = mi->bank[1].start + mi->bank[1].size;
206
 	ram_console_size = SZ_1M - SZ_4K;
207
 
208
 	pm_debug_scratchpad = ram_console_start + ram_console_size;
209
</pre>
210
211
<pre>
212
diff --git a/BoardConfigCommon.mk b/BoardConfigCommon.mk
213
index fff6d1b..c09d935 100755
214
--- a/BoardConfigCommon.mk
215
+++ b/BoardConfigCommon.mk
216
@@ -51,10 +51,10 @@ DEFAULT_FB_NUM := 2
217
 
218
 BOARD_NAND_PAGE_SIZE := 4096 -s 128
219
 
220
-BOARD_KERNEL_BASE := 0x30000000
221
+BOARD_KERNEL_BASE := 0x40000000
222
 BOARD_KERNEL_PAGESIZE := 4096
223
-BOARD_KERNEL_CMDLINE := console=ttyFIQ0 no_console_suspend
224
-
225
+BOARD_KERNEL_CMDLINE := console=ttyFIQ0 no_console_suspend earlyprintk=serial,ttySAC2,115200 bootmem_debug
226
+BOARD_FORCE_RAMDISK_ADDRESS := 0x41000000
227
 #TARGET_RECOVERY_UI_LIB := librecovery_ui_crespo
228
 TARGET_RELEASETOOLS_EXTENSIONS := device/samsung/crespo
229
</pre>